syncPricePerShare on Polygon #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atvanguard
commented
Jul 7, 2021
Comment on lines
+1396
to
+1400
| address public fxChild; | ||
| address public fxRootTunnel; | ||
| uint public pricePerShare; | ||
|
|
||
| event PricePerShareUpdated(uint indexed pricePerShare); |
There was a problem hiding this comment.
These are being added to a proxy that already has been deployed. Please verify that adding variables at the end is safe.
There was a problem hiding this comment.
Adding vars at the end won't be an issue if this contract isn't used as a parent contract of another
dapp-whisperer
approved these changes
Jul 7, 2021
Comment on lines
+1396
to
+1400
| address public fxChild; | ||
| address public fxRootTunnel; | ||
| uint public pricePerShare; | ||
|
|
||
| event PricePerShareUpdated(uint indexed pricePerShare); |
There was a problem hiding this comment.
Adding vars at the end won't be an issue if this contract isn't used as a parent contract of another
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.