Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release template & update contributing #2486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schristoff-du
Copy link
Contributor

No description provided.

@schristoff-du schristoff-du requested a review from a team as a code owner May 8, 2024 19:48
Copy link

netlify bot commented May 8, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 17a5f77
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/663bd719261c960008098c91

Copy link
Member

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Release Manager:

Release checklist:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add merging the goreleaser PR in the homebrew-tap repo as a step in the release checklist


[ ] `export RELEASE_VERSION=v0.33.1`

[ ] `git tag -sa $RELEASE_VERSION -m "$RELEASE_VERSION" `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to note that the tag has to be pushed to remote:

git push origin "$RELEASE_VERSION"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants