FileSimilarityRetriever - Add readme, fix mypy linter issues #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augchan42
requested review from
dfokina and
masci
and removed request for
a team
augchan42
changed the title
masci
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Hi @augchan42 and thanks for your contribution.
Can you give me a bit of context here? Ideally we have a template for PR descriptions.
In particular, why are you targeting the file-similarity-retriever-code branch? That's a branch that was created to bake this proposal , which hasn't been approved yet so I would need to go and check its status.
Any detail you can give me would me much appreciated!
|
Just saw this PR with a new feature that's been sitting there for months and noticed it may have been due to failing some automated checks. |
|
Ah I see, you're contributing to #5666, fine by me 👍 |
masci
merged commit 59b3266
into
deepset-ai:file-similarity-retriever-code
66 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.