refactor: bump pydantic to v2 using v1 API #5917

mjspeck · 2023-09-29T00:16:40Z

Related Issues

fixes Migrate to Pydantic V2 #5304

Proposed Changes:

This PR works as a stopgap solution to updating the pydantic dependency to V2. It uses the v1 API by using pydantic v2's v1 submodule.

How did you test it?

I started unit tests on my computer but they took too long. So per the contributing guidelines I'm waiting for tests to run in the CI pipeline.

Notes for the reviewer

All pydantic imports have just been modified to include .v1.

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
I documented my code
I ran pre-commit hooks and fixed any issue

CLAassistant · 2023-09-29T00:16:47Z

All committers have signed the CLA.

silvanocerza

I see lot of unrelated changes in this PR.
Given that it's an important update could you try and keep the changes at a minimum? As much as I like to keep things tidy and in order I think it's best if we don't reformat imports and other files in this case.
It makes it much harder for us to review it too.

mjspeck · 2023-09-29T17:52:11Z

I see lot of unrelated changes in this PR. Given that it's an important update could you try and keep the changes at a minimum? As much as I like to keep things tidy and in order I think it's best if we don't reformat imports and other files in this case. It makes it much harder for us to review it too.

Done.

silvanocerza · 2023-09-29T19:00:42Z

@mjspeck can you revert the formatting for pyproject.toml too please?

mjspeck · 2023-09-29T19:09:11Z

@mjspeck can you revert the formatting for pyproject.toml too please?

Done

coveralls · 2023-10-02T20:22:42Z

Pull Request Test Coverage Report for Build 6384187858

0 of 0 changed or added relevant lines in 0 files are covered.
103 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.006%) to 50.285%

Files with Coverage Reduction	New Missed Lines	%
pipelines/ray.py	1	21.98%
utils/context_matching.py	1	95.7%
nodes/_json_schema.py	17	87.27%
schema.py	84	68.62%

Totals
Change from base Build 6369977992:	-0.006%
Covered Lines:	12514
Relevant Lines:	24886

💛 - Coveralls

silvanocerza · 2023-10-02T20:28:49Z

@mjspeck seems like the REST API tests are failing for some reason.
I would have expected v1 through v2 to have the same behaviour but it seems it doesn't. 🤔

mjspeck · 2023-10-02T22:01:47Z

@mjspeck seems like the REST API tests are failing for some reason. I would have expected v1 through v2 to have the same behaviour but it seems it doesn't. 🤔

Yeah I'm surprised. I'll see what I can do this week.

mjspeck · 2023-10-04T01:19:19Z

After doing some more testing and digging, it seems that this is an issue with FastAPI. We can either leave this as a draft for now and wait for FastAPI to fix the issue or close it. Just a note, it looks like there's already a PR in there to address this so waiting might not be a bad option.

silvanocerza · 2023-10-04T15:52:24Z

@mjspeck nice find, let's wait for that issue to be solved. 👍

Snuggert · 2023-11-16T12:33:36Z

That issue has been solved in the latest release of fastapi:
tiangolo/fastapi#10344

There is another dependency issue currently blocking the move to fastapi 0.104:
#6119

silvanocerza · 2023-11-27T08:38:19Z

Force pushed to fix conflicts.

silvanocerza · 2023-11-27T09:43:22Z

This still doesn't seem solved. 😕

This doesn't update the code to use the pydantic v2 API, it uses pydantic's v1 submodule as an intermediate step to allow updating the dependency.

This reverts commit ee8337e.

silvanocerza · 2024-01-10T17:18:18Z

Rebased to fix conflicts. 🤞

silvanocerza · 2024-04-04T14:09:52Z

Closing, we won't do this.

github-actions bot added topic:rest_api topic:elasticsearch topic:pipeline topic:document_store topic:tests topic:dependencies topic:opensearch topic:build/distribution topic:DX Developer Experience proposal type:documentation Improvements on the docs labels Sep 29, 2023

mjspeck changed the title ~~Pydantic v2 interim~~ chore: bump pydantic to v2 using v1 API Sep 29, 2023

mjspeck changed the title ~~chore: bump pydantic to v2 using v1 API~~ refactor: bump pydantic to v2 using v1 API Sep 29, 2023

silvanocerza reviewed Sep 29, 2023

View reviewed changes

mjspeck force-pushed the pydantic-v2-interim branch from dd225ed to 41fa2d6 Compare September 29, 2023 18:04

github-actions bot removed topic:DX Developer Experience proposal labels Sep 29, 2023

mjspeck force-pushed the pydantic-v2-interim branch 3 times, most recently from 2129917 to fb4b54c Compare September 29, 2023 18:43

mjspeck marked this pull request as ready for review September 29, 2023 18:46

mjspeck requested review from a team as code owners September 29, 2023 18:46

mjspeck requested review from dfokina and silvanocerza and removed request for a team September 29, 2023 18:46

mjspeck marked this pull request as draft October 2, 2023 22:02

masci assigned silvanocerza Nov 23, 2023

masci changed the base branch from main to v1.x November 24, 2023 12:06

masci added the 1.x label Nov 24, 2023

silvanocerza force-pushed the pydantic-v2-interim branch from 814c9f1 to a764056 Compare November 27, 2023 08:38

mjspeck added 6 commits January 10, 2024 18:15

refactor: update pydantic dependency to v2

8271604

This doesn't update the code to use the pydantic v2 API, it uses pydantic's v1 submodule as an intermediate step to allow updating the dependency.

chore: reformat markdown files to follow linting rules

7539f06

chore: added releasenotes for pydantic bump

e940b30

Revert "chore: reformat markdown files to follow linting rules"

7539401

This reverts commit ee8337e.

chore: revert import sorting

89d6915

chore: undid formatting in pyproject.toml

60e3e5f

silvanocerza force-pushed the pydantic-v2-interim branch from a764056 to 60e3e5f Compare January 10, 2024 17:17

silvanocerza closed this Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: bump pydantic to v2 using v1 API #5917

refactor: bump pydantic to v2 using v1 API #5917

mjspeck commented Sep 29, 2023 •

edited

CLAassistant commented Sep 29, 2023 •

edited

silvanocerza left a comment

mjspeck commented Sep 29, 2023 •

edited

silvanocerza commented Sep 29, 2023

mjspeck commented Sep 29, 2023

coveralls commented Oct 2, 2023

silvanocerza commented Oct 2, 2023

mjspeck commented Oct 2, 2023

mjspeck commented Oct 4, 2023 •

edited

silvanocerza commented Oct 4, 2023

Snuggert commented Nov 16, 2023

silvanocerza commented Nov 27, 2023

silvanocerza commented Nov 27, 2023

silvanocerza commented Jan 10, 2024

silvanocerza commented Apr 4, 2024

refactor: bump pydantic to v2 using v1 API #5917

refactor: bump pydantic to v2 using v1 API #5917

Conversation

mjspeck commented Sep 29, 2023 • edited

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

CLAassistant commented Sep 29, 2023 • edited

silvanocerza left a comment

Choose a reason for hiding this comment

mjspeck commented Sep 29, 2023 • edited

silvanocerza commented Sep 29, 2023

mjspeck commented Sep 29, 2023

coveralls commented Oct 2, 2023

Pull Request Test Coverage Report for Build 6384187858

💛 - Coveralls

silvanocerza commented Oct 2, 2023

mjspeck commented Oct 2, 2023

mjspeck commented Oct 4, 2023 • edited

silvanocerza commented Oct 4, 2023

Snuggert commented Nov 16, 2023

silvanocerza commented Nov 27, 2023

silvanocerza commented Nov 27, 2023

silvanocerza commented Jan 10, 2024

silvanocerza commented Apr 4, 2024

mjspeck commented Sep 29, 2023 •

edited

CLAassistant commented Sep 29, 2023 •

edited

mjspeck commented Sep 29, 2023 •

edited

mjspeck commented Oct 4, 2023 •

edited