Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and organization of the test script file for better understanding #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edumucelli
Copy link

@edumucelli edumucelli commented Aug 5, 2019

@nttstar thanks for the work you have done so far! This PR tries to improve the readability and the code organization for the test script. To gain some understanding on how RetinaFace is used, I have rewritten it with two things in mind:

  1. Make it easier for other people reading it by naming variables with what they are, e.g., instead of l==0 I have used EYE_RIGHT_LANDMARK, which is more clear.
  2. Use Python PEP8 conventions.

I have also added the example image from the paper, i.e., the largest-selfie one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant