Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

203 display selections metadata #204

Merged
merged 11 commits into from
Jun 27, 2024
Merged

203 display selections metadata #204

merged 11 commits into from
Jun 27, 2024

Conversation

FadyCoding
Copy link
Contributor

Describe your changes

Added selections metadata when hovering on the documentation button. Corrected the models metadata positions as well to have a more consistent feature*.

Screenshots (if appropriate):

image

Issue ticket number and link

#203

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have increased the version number in the frontend/package.json and backend/swagger.yaml files
  • I have checked that Black, Flake8, Prettier and Cspell are passing

@FadyCoding FadyCoding linked an issue Jun 4, 2024 that may be closed by this pull request
Display selections metadata #203
Closed
5 tasks
@FadyCoding FadyCoding requested a review from Tomansion June 4, 2024 13:55
@FadyCoding FadyCoding self-assigned this Jun 4, 2024
Tomansion
Tomansion requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Tomansion Tomansion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few details and good

frontend/src/components/debiai/project/Models.vue Outdated Show resolved Hide resolved
backend/swagger.yaml Outdated Show resolved Hide resolved
backend/swagger.yaml Outdated Show resolved Hide resolved
backend/swagger.yaml Outdated Show resolved Hide resolved
@Tomansion Tomansion merged commit f9698bc into main Jun 27, 2024
10 checks passed
@Tomansion Tomansion deleted the 203-display-selections-metadata branch June 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomansion Tomansion Tomansion approved these changes

Assignees

@FadyCoding FadyCoding

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display selections metadata
2 participants
@FadyCoding @Tomansion