Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

194 display models metadata #196

Merged
merged 12 commits into from
Apr 30, 2024
Merged

194 display models metadata #196

merged 12 commits into from
Apr 30, 2024

Conversation

FadyCoding
Copy link
Contributor

Describe your changes

Added a documentation button that displays on hover the metadata of models.

Screenshots (if appropriate):

image

Issue ticket number and link

#194

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have increased the version number in the frontend/package.json and backend/swagger.yaml files
  • I have checked that Black, Flake8, Prettier and Cspell are passing

@FadyCoding FadyCoding linked an issue Apr 22, 2024 that may be closed by this pull request
6 tasks
@FadyCoding FadyCoding self-assigned this Apr 22, 2024
Copy link
Member

@Tomansion Tomansion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required 👍

backend/swagger.yaml Outdated Show resolved Hide resolved
backend/swagger.yaml Outdated Show resolved Hide resolved
backend/swagger.yaml Outdated Show resolved Hide resolved
frontend/src/components/debiai/project/Models.vue Outdated Show resolved Hide resolved
frontend/src/services/services.js Outdated Show resolved Hide resolved
frontend/src/components/debiai/project/Models.vue Outdated Show resolved Hide resolved
Copy link
Member

@Tomansion Tomansion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some few details

backend/swagger.yaml Outdated Show resolved Hide resolved
@Tomansion
Copy link
Member

Tomansion commented Apr 29, 2024

Nice work so far but I detected some issues with some specific metadata values:

{
      searchBar: "",
      selectedModelIds: [],
      commonModelResults: true,
      testJsonMetadata: {
        test: "test",
        array: [1, 2, 3],
        array2: [
          {
            test: "test",
            array: [1, 2, 3],
          },
          "test",
          1,
          29279827,
        ],
      },
}

Gives:
image

This will need fixing

Copy link
Member

@Tomansion Tomansion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done ( ͡ᵔ ͜ʖ ͡ᵔ) 👍

@Tomansion Tomansion merged commit a966aa4 into main Apr 30, 2024
10 checks passed
@Tomansion Tomansion deleted the 194-display-models-metadata branch April 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Display models metadata
2 participants