Added 2 backends for running target functions with support to set per_attempt_timeout for target functions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandsanto
commented
Jun 7, 2021
anandsanto
commented
- 'multithreading' and 'multiprocessing' backends
- Added support for per_attempt_timeout so that an attempt does exceed this timout
- In 'multiprocessing' backend, the child process running the target is killed after the per_attempt_timeout to free resources
- 'multithreading' and 'multiprocessing' backends - Added support for per_attempt_timeout so that an attempt does exceed this timout - In 'multiprocessing' backend, the child process running the target is killed after the per_attempt_timeout to free resources
|
Hi @anandsanto sorry for being slow to review this. I saw the PR and then forgot about it, as I got distracted. Apologies for this. This looks like an interesting extension to the polling function. The multithreading and muliprocessing is cool. I haven't written a lot of multi-threaded applications. So I'm a bit of a novice with parallel code. I'm beginning to think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.