build: standardize apt-get usage, remove blackfire from apt sources, for #6235, for #6078 #6236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
apt-get update
can fail in the user's custom Dockerfiles.I thought we could search for
apt-get update
using a regex and automatically replace it in the resulting Dockerfile, but that seems like overkill because people can write it with different variations, like:apt-get update
apt-get update -y
apt-get update -qq
apt-get update -qq >/dev/null
And the same with
apt
, so it's probably impossible to write a good regex to cover all cases and not break anything.How This PR Solves The Issue
Replaces
apt-get update
with(apt-get update || true)
in the docs.Uses
apt-get
instead ofapt
everywhere.Removes
/etc/apt/sources.list.d/blackfire.list
as we pin the blackfire package to a specific version and don't need it inapt-get update
:Manual Testing Instructions
ddev start
ddev ssh
sudo apt-get update | grep blackfire
should give an empty resultAutomated Testing Overview
Related Issue Link(s)
Release/Deployment Notes