Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix broken tests, for #5813 #6232

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

stasadev
Copy link
Member

The Issue

Buildkite error:

ls: cannot access '/C:\Users\testbot\tmp\ddevtest\Home_VRAjq683975830\ddev': No such file or directory

How This PR Solves The Issue

The error is a result of my refactoring in:

I thought the path would look like /c/Users/..., but it is C:\Users\...

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner May 22, 2024 19:49
Copy link

github-actions bot commented May 22, 2024

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for watching and catching!

@rfay
Copy link
Member

rfay commented May 23, 2024

I think we have trouble with Rancher and Colima as well. People wonder how we spend all our time as software developers :)

@rfay
Copy link
Member

rfay commented May 23, 2024

Restarted a number of tests. Note that Colima has had a version update which was not supposed to affect anything, but it's updated via brew on all 3 arm64 machines.

@rfay
Copy link
Member

rfay commented May 23, 2024

Thanks for being so smart to create this branch on ddev/ddev so we can properly solve this problems. If it's OK, let's fix all 3 things here in this PR.

@stasadev stasadev force-pushed the 20240522_stasadev_fix_windows_test branch from c757830 to ae1d7be Compare May 23, 2024 22:32
@stasadev stasadev changed the title test: fix TestConfigGitignore on Windows test: fix broken tests, for #5813 May 23, 2024
@stasadev stasadev merged commit 70fc4cd into master May 24, 2024
20 checks passed
@stasadev stasadev deleted the 20240522_stasadev_fix_windows_test branch May 24, 2024 15:05
jonesrussell pushed a commit to jonesrussell/ddev that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants