This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Changes towards v1.0-beta1 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt-gt
force-pushed
the
update-next-phase-2
branch
from
b741cba
to
9b3c752
Compare
Signed-off-by: Niels Thykier <[email protected]>
Note that algorithm for key cloak was not changed. It is only used for internal testing and the test failed, when it was changed. Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
It is a document wide attribute and cannot be changed on a per-action level anyway. Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
It should be mandatory, but that will come later when we are ready to rewrite all the test data. Signed-off-by: Niels Thykier <[email protected]>
nt-gt
force-pushed
the
update-next-phase-2
branch
from
b281af6
to
acc9c79
Compare
Signed-off-by: Niels Thykier <[email protected]>
douradofrazer
suggested changes
Jul 20, 2023
ec-service/src/test/java/org/dcsa/endorsementchain/service/PartyServiceTest.java
Show resolved
Hide resolved
ec-service/src/main/java/org/dcsa/endorsementchain/mapping/SupportingPartyCodeMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Niels Thykier <[email protected]>
douradofrazer
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.