This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Readme updates and refactoring #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
Perform the rename every where except if it would affect the external API. The omission ensures that we can use existing CI to verify the rename did not break anything and keep the code working (on the previous version of the API). Also added a couple of TODOs when I spotted something wrong. However, I did not fix them in this commit as it would mix refactoring with semantic changes and would make this commit considerably harder to review. Signed-off-by: Niels Thykier <[email protected]>
Signed-off-by: Niels Thykier <[email protected]>
douradofrazer
approved these changes
Jun 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides updating the readme, this PR also renames some of the entities internally to prepare for the upcoming 0.12 rewrite.
During the refactoring, I spotted some weird things where I placed a TODO to follow up on it later rather than change it immediately (this is to keep the changes a pure refactoring without "sneaking in" a semantic change).