Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver/dbeaver#23349 [CrateDB] ER diagrams can't be opened #33402

Merged
merged 5 commits into from
May 23, 2024

Conversation

serjiokov
Copy link
Contributor

No description provided.

@serjiokov serjiokov linked an issue May 22, 2024 that may be closed by this pull request
Covered by logger instead of throw exception
@E1izabeth
Copy link
Member

E1izabeth commented May 22, 2024

Please give some explanations of your PR - we need to know why we can't show ER diagrams in CrateDB in the future. Also I wonder how does it look like (where do we see this error message)?

@LonwoLonwo
Copy link
Member

I think the problem here is the inability to read table references. You need to hide foreign keys or find the correct way to read them.

@serjiokov
Copy link
Contributor Author

Not, exactly true, not needed to fix data base if it has implementation issue. The idea behind, don't to throw any exceptions if you already have enough details. Instead we have to log non critical exception and proceed visialisation.

@E1izabeth
Copy link
Member

E1izabeth commented May 22, 2024

So, do ER diagrams work now? Please add description to this PR.

@serjiokov
Copy link
Contributor Author

Yes it is working for crateDB
image

@Matvey16
Copy link
Member

Verified

@serge-rider serge-rider merged commit c7b4afb into devel May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CrateDB] ER diagrams can't be opened
5 participants