Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archiving #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix archiving #8

wants to merge 3 commits into from

Conversation

PatrikTheDev
Copy link
Contributor

Fixed archiving (at least for me)

@davbeck
Copy link
Owner

davbeck commented Nov 13, 2019

What exactly are you trying to fix here?

@PatrikTheDev
Copy link
Contributor Author

When I try to archive your version, it fails because it can’t find Combine, this fixes it (or another fix is to just change the required version to 13 but that’s not a good solution)

@davbeck
Copy link
Owner

davbeck commented Nov 13, 2019

Archiving how? For what? Do you mean when you try to archive an app that links to this framework? Are you trying to archive the framework itself? Using Xcode or some other means?

This implies that you are trying to compile the framework with an older version of Xcode, in which case it would not include any of the code at all.

@PatrikTheDev
Copy link
Contributor Author

Archiving it with Xcode 11.2.1 (or building for production, the same thing happens). It’s the way to upload to App Store connect. Try it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants