Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] history and sorting for dmenu mode #609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[wip] history and sorting for dmenu mode #609

wants to merge 1 commit into from

Conversation

awalgarg
Copy link
Contributor

Alright, this is a veeeery rough patch, mostly intended to start discussion as discussed in irc.

Things we should probably do/change:

  • The history setting should be done at once after stdout is completely flushed. This is for when in multi-select mode. Pretty small thing tbh, but maybe it matters.
  • Not that great at C so dunno if code is idiomatic.
  • Make it work with async mode.

@codecov-io
Copy link

Codecov Report

Merging #609 into master will decrease coverage by 0.02%.
The diff coverage is 64.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   73.98%   73.95%   -0.03%     
==========================================
  Files          37       37              
  Lines        9163     9178      +15     
==========================================
+ Hits         6779     6788       +9     
- Misses       2384     2390       +6
Impacted Files Coverage Δ
source/dialogs/dmenu.c 69.72% <64.7%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e6c33...353dece. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants