Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKC-600 Refactor documentation for 3.0 #1251

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

SPARKC-600 Refactor documentation for 3.0 #1251

wants to merge 42 commits into from

Conversation

ianjevans
Copy link

Description

SPARKC-600

Converted existing Markdown files to Asciidoc. Restructured docs into Antora modules. Added workflow to generate docs using Antora and publish to GitHub Pages. Modified reference generator to output Asciidoc file.

How did the Spark Cassandra Connector Work or Not Work Before this Patch

Docs were difficult to navigate, and weren't published as a docset.

General Design of the patch

Converted and updated the docs to use Asciidoc syntax. Refactored the docs into Antora modules to make them easier to navigate, and update going forward. Added Antora configuration files to use a DataStax UI bundle to match the current look-and-feel. Added GitHub Action workflow to automatically generate and publish the docs on push to GitHub Pages.

How Has This Been Tested?

Ran local unit tests.

Checklist:

  • I have a ticket in the OSS JIRA
  • I have performed a self-review of my own code
  • Locally all tests pass (make sure tests fail without your patch)

@ianjevans ianjevans changed the title Refactor documentation for 3.0 SPARKC-600 Refactor documentation for 3.0 Jun 18, 2020
@jtgrabowski
Copy link
Collaborator

@ianjevans may I review this one?

@ianjevans
Copy link
Author

ianjevans commented Jun 26, 2020 via email

Copy link
Contributor

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit worried about us breaking all existing links to documentation with this change. There are a large number of resources out in the world which link to the docs as is in markdown and this will change all of those links to 404's. We should probably retain those endpoints and have them link to the new relevant docs.

@ianjevans
Copy link
Author

I am a bit worried about us breaking all existing links to documentation with this change. There are a large number of resources out in the world which link to the docs as is in markdown and this will change all of those links to 404's. We should probably retain those endpoints and have them link to the new relevant docs.

I really wish GitHub had the concept of file redirects, since this is a side-effect of using the GItHub repo web renderer. If the doc links were to e.g. GitHub Pages we could redirect to the new locations and file names, and that will hopefully be the model going forward for maintainability.

If we could figure out a solution that doesn't involve keeping all 20 of the old .md files around indefinitely, I'd vastly prefer that, but I don't have any clever ideas. Are most of the links to the quick start and e.g. connecting?

@jtgrabowski
Copy link
Collaborator

@ianjevans Is there a way we could leverage work that's been done here and at the same time don't break all the old .md files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants