SPARKC-504: Allow null UDTs against b3.0 branch #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,7 +208,7 @@ object MappedToGettableDataConverter extends StrictLogging { | |||
| for (i <- columnValues.indices) | |||
| columnValues(i) = converters(i).convert(columnValues(i)) | |||
| struct.newInstance(columnValues: _*) | |||
| case None => | |||
| case _ => | |||
There was a problem hiding this comment.
Yeah my comment on _ was just that I thought we would explicitly match None and null just incase some other object got to this point in the match. I know that's impossible I just worry sometimes.
There was a problem hiding this comment.
If you see the case on line 204, "case obj if obj == null" Why doesn't this case match?
There was a problem hiding this comment.
I tried
it should "convert null UDTs to null" in {
val userTable = newTable(loginColumn, passwordColumn)
val converter = MappedToGettableDataConverter[UserWithOption](userTable, userTable.columnRefs)
val row = converter.convert(null)
row shouldEqual null
}
And this test passes without this code change, I think I may be missing something here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #1228 rebased on b3.0