Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove install_snapshot v0 meta-service API #15590

Merged

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented May 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: Remove install_snapshot v0 meta-service API

Compatibility Changes:

This commit introduces changes to inter-meta-service compatibility,
although compatibility between databend-query and meta-service
remains unaffected.

Details:

  • The initial snapshot transmission API, install_snapshot (v0), has
    been removed from both the meta server and meta client sides.

  • For clients, the use of install_snapshot_v1() transitions from
    OPTIONAL to REQUIRED.

Version Requirements:

  • Post this commit, the meta-server requires clients to be at least
    version 1.2.212, starting from which the clients began using
    install_snapshot_v1().

  • Similarly, clients require the server to be at least version
    1.2.212, which is the version where install_snapshot_v1() becomes
    available.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 20, 2024
**Compatibility Changes:**

This commit introduces changes to inter-meta-service compatibility,
although compatibility between databend-query and meta-service
remains unaffected.

**Details:**

- The initial snapshot transmission API, `install_snapshot` (v0), has
  been removed from both the meta server and meta client sides.

- For clients, the use of `install_snapshot_v1()` transitions from
  **OPTIONAL** to **REQUIRED**.

**Version Requirements:**

- Post this commit, the meta-server requires clients to be at least
  version `1.2.212`, starting from which the clients began using
  `install_snapshot_v1()`.

- Similarly, clients require the server to be at least version
  `1.2.212`, which is the version where `install_snapshot_v1()` becomes
  available.
@drmingdrmer drmingdrmer force-pushed the 84-remove-install-snapshot-v0 branch from 7cbd998 to 57d0dc7 Compare May 21, 2024 01:29
@drmingdrmer drmingdrmer marked this pull request as ready for review May 21, 2024 01:29
@drmingdrmer drmingdrmer merged commit 790bd8e into datafuselabs:main May 21, 2024
75 checks passed
@drmingdrmer drmingdrmer deleted the 84-remove-install-snapshot-v0 branch May 21, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant