Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use managed upload token for codecov.io #1463

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Use managed upload token for codecov.io #1463

merged 4 commits into from
Apr 19, 2024

Conversation

nfx
Copy link
Member

@nfx nfx commented Apr 19, 2024

v4 of codecov-action no longer supports tokenless upload. Let's try avoiding tokens altogether by using OIDC. OIDC doesn't seem to work: codecov/codecov-action#1378, using managed CODECOV_TOKEN secrets.

v4 of codecov-action no longer supports tokenless upload. Let's try avoiding tokens altogether by using OIDC.
@nfx nfx requested a review from a team as a code owner April 19, 2024 15:49
@nfx nfx requested a review from ericvergnaud April 19, 2024 15:49
@nkvuong nkvuong linked an issue Apr 19, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (b2a11cf) to head (aadc327).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   90.02%   88.17%   -1.86%     
==========================================
  Files          62       77      +15     
  Lines        7430     9443    +2013     
  Branches     1335     1669     +334     
==========================================
+ Hits         6689     8326    +1637     
- Misses        470      744     +274     
- Partials      271      373     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx changed the title Use OIDC for codecov.io Use managed upload token for codecov.io Apr 19, 2024
@nfx nfx merged commit 6a5e4f6 into main Apr 19, 2024
6 of 7 checks passed
@nfx nfx deleted the fix/codecov branch April 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Code coverage is desactivated on all PRs
1 participant