-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature constraints #257
Feature constraints #257
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 92.14% 92.70% +0.55%
==========================================
Files 23 33 +10
Lines 2788 3029 +241
Branches 477 523 +46
==========================================
+ Hits 2569 2808 +239
- Misses 130 131 +1
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
…bs/dbldatagen into feature_constraints merge from upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably add comments to the abstract classes instead of using ABC
…bs/dbldatagen into feature_constraints merge from upstream
Proposed changes
Added support for constraints
Types of changes
What types of changes does your code introduce to dbldatagen?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...