Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature constraints #257

Merged
merged 28 commits into from
May 28, 2024
Merged

Feature constraints #257

merged 28 commits into from
May 28, 2024

Conversation

ronanstokes-db
Copy link
Contributor

Proposed changes

Added support for constraints

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@ronanstokes-db ronanstokes-db requested a review from a team as a code owner March 13, 2024 22:27
@ronanstokes-db ronanstokes-db requested review from GeekSheikh and removed request for a team March 13, 2024 22:27
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 99.17355% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.70%. Comparing base (b28602d) to head (d194069).

Files Patch % Lines
dbldatagen/constraints/constraint.py 96.96% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   92.14%   92.70%   +0.55%     
==========================================
  Files          23       33      +10     
  Lines        2788     3029     +241     
  Branches      477      523      +46     
==========================================
+ Hits         2569     2808     +239     
- Misses        130      131       +1     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronanstokes-db ronanstokes-db self-assigned this Mar 15, 2024
@ronanstokes-db ronanstokes-db added the enhancement New feature or request label Apr 10, 2024
@ronanstokes-db ronanstokes-db added this to the v0.3.7 milestone Apr 10, 2024
Copy link

@howardwu-db howardwu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably add comments to the abstract classes instead of using ABC

dbldatagen/column_spec_options.py Outdated Show resolved Hide resolved
dbldatagen/constraints/constraint.py Outdated Show resolved Hide resolved
dbldatagen/constraints/constraint.py Show resolved Hide resolved
dbldatagen/constraints/constraint.py Show resolved Hide resolved
dbldatagen/constraints/constraint.py Outdated Show resolved Hide resolved
@ronanstokes-db ronanstokes-db merged commit 82ce5ce into master May 28, 2024
5 checks passed
@ronanstokes-db ronanstokes-db deleted the feature_constraints branch May 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants