feat: Let addrman handle multiple ports for all networks #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvg
approved these changes
Jun 15, 2024
PastaPastaPasta
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
utACK 76b4300; is it really a fix or a refactor? doesn't change observable system behavior
|
It changes the internals of |
UdjinM6
changed the title
knst
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There is really no need to do have this restriction in
addrman, we checkAllowMultiplePorts()inconnmanwhich should be enough already. We can safely re-alignaddrmanto its upstream implementation as suggested in #6043.What was done?
Drop port "discrimination" in
addrman, remove related tests.How Has This Been Tested?
Run tests, run dash-qt on mainnet/testnet
Breaking Changes
n/a
Checklist: