Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid on-appear calls in tab views #3

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix invalid on-appear calls in tab views #3

wants to merge 7 commits into from

Conversation

darrarski
Copy link
Owner

@darrarski darrarski commented Apr 12, 2021 •
edited

What was done

  • Updated the code so the issue Duplicated/invalid actions are received when tab view appear #2 can be reproduced.
  • Updated ComposableArchitecture dependency.
  • Added TabsViewState to prevent unneeded updates of the TabsView.
  • Tried moving .onAppear(perform:) modifiers outside the WithViewStore.
  • Found a workaround by moving .onAppear(perform:) from each tab view to TabsView.

@darrarski darrarski added the bug Something isn't working label Apr 12, 2021
@darrarski darrarski self-assigned this Apr 12, 2021
@darrarski darrarski linked an issue Apr 12, 2021 that may be closed by this pull request
Duplicated/invalid actions are received when tab view appear #2
Open
@darrarski darrarski added the help wanted Extra attention is needed label Apr 12, 2021
@darrarski darrarski mentioned this pull request Apr 12, 2021
Open
@darrarski darrarski marked this pull request as draft April 12, 2021 17:21
@darrarski darrarski assigned darrarski and unassigned darrarski Apr 12, 2021
@darrarski darrarski changed the title Fix invalid on appear calls in tab views Fix invalid on-appear calls in tab views Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@darrarski darrarski

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated/invalid actions are received when tab view appear
1 participant
@darrarski