Add circuits.vcn.com to dynamic-theme-fixes.config #12687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes images on a site that my company uses for work more readable in dark mode. It also makes selection boxes readable. Since this is a private access website, I understand if this won't be accepted, but I'm not sure how to make the changes automatically apply when I open up the site for the first time without having to go into dev tools and apply them there. Other users of the site at my company would appreciate this very much, since not everyone is technical enough to figure this out. Let me know if you want pictures of how this looks in dark mode and light mode, or if you need anything else.
|
Here are some before and after screenshots of what I'm talking about: |
|
And for the selections: |
|
And feel free to remove the img CSS selector from this. I don't know why that's in there and it looks a lot cleaner without it. |
alexanderby
requested changes
May 6, 2024
This uses darkreader variables for colors instead of hard coded ones and adds some CSS to make the select arrows visible in certain forms that otherwise are not visible in dark mode.
alexanderby
requested changes
May 8, 2024
This increases the specificity of the images to invert by only inverting those that are sourced from a graph-like url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes images on a site that my company uses for work more readable in dark mode. It also makes selection boxes readable. Since this is a private access website, I understand if this won't be accepted, but I'm not sure how to make the changes automatically apply when I open up the site for the first time without having to go into dev tools and apply them there. Other users of the site at my company would appreciate this very much, since not everyone is technical enough to figure this out. Let me know if you want pictures of how this looks in dark mode and light mode, or if you need anything else.