Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for revolver.news #12683

Merged
merged 1 commit into from May 8, 2024
Merged

Fix for revolver.news #12683

merged 1 commit into from May 8, 2024

Conversation

light-orth
Copy link
Contributor

Article titles and category on main page unaffected by color changes as stated in #12655.

My attempt at a simple fix for this by inverting the elements instead.

Articles titles and category on main page unaffected by color changes, fixed their color by inverting.
@alexanderby
Copy link
Member

I need to figure out why the CSS fix didn't work (and possibly why the text is dark in the first place).

@alexanderby alexanderby added the bug label May 6, 2024
@alexanderby
Copy link
Member

alexanderby commented May 8, 2024

The problem it doesn't work is style="color: rgb(0, 0, 0) !important;". The important inline styles have the highest precedence. There is a way to fix this by overwriting the color, but it may lead to issues on many other websites.

@alexanderby alexanderby merged commit aa9a740 into darkreader:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants