Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic icon support #124

Closed

Conversation

shatanikmahanty
Copy link
Contributor

@shatanikmahanty shatanikmahanty commented Oct 16, 2023

Changes app icon based on weather data.

Future enhancements that are work in progress:

  • Figure out a way to change app icon on every weather update cycle rather than only on location change or app open
  • Optimise change icon call by checking if the current icon is same as the one we are trying to change to
  • Let users decide if they want this feature through a switch in settings. By default I will keep this false as android restarts app on changing icon
  • Let users decide if the icon changes on closing app or instantly

@saltsoftdrink
Copy link

Changes app icon based on weather data.

Future enhancements that are work in progress:

* [ ]  Figure out a way to change app icon on every weather update cycle rather than only on location change or app open

* [ ]  Optimise change icon call by checking if the current icon is same as the one we are trying to change to

* [ ]  Let users decide if they want this feature through a switch in settings. By default I will keep this false as android restarts app on changing icon

* [ ]  Let users decide if the icon changes on closing app or instantly

Is this PR dead

@shatanikmahanty
Copy link
Contributor Author

Changes app icon based on weather data.

Future enhancements that are work in progress:

* [ ]  Figure out a way to change app icon on every weather update cycle rather than only on location change or app open

* [ ]  Optimise change icon call by checking if the current icon is same as the one we are trying to change to

* [ ]  Let users decide if they want this feature through a switch in settings. By default I will keep this false as android restarts app on changing icon

* [ ]  Let users decide if the icon changes on closing app or instantly

Is this PR dead

@saltsoftdrink I was having a lot of work pressure for the past months and forgot about this in the meanwhile. I will try to work on this in the coming weekends.

@shatanikmahanty shatanikmahanty marked this pull request as draft March 17, 2024 16:06
@shatanikmahanty
Copy link
Contributor Author

Latest update on this.

  • change app icon on every weather update cycle rather than only on location change or app open
  • Optimise change icon call by checking if the current icon is same as the one we are trying to change to
  • Let users decide if they want this feature through a switch in settings. By default I will keep this false as android restarts app on changing icon

Converted the PR to draft as I need to test my changes over the next weekend! Also need to plan if I will work on the following point in this PR or in a different PR as without this as well the functionality is solid in my opinion:

  • Let users decide if the icon changes on closing app or instantly

@shatanikmahanty
Copy link
Contributor Author

If anyone wants to review this and test changes in the meanwhile maybe it can be merged earlier than next weekend as well 😁

@shatanikmahanty
Copy link
Contributor Author

shatanikmahanty commented May 10, 2024

Hey folks here's the latest update on this:

After some testing and research, I found out that changing the app icon through background processes is not possible. So the initial promise of the app supporting dynamic icons throughout the whole day won't be supported. Also, it has limited support on some custom Android OEMs. I think we should close this PR without merging. Sorry if I got your hopes up with this one, but it didn't turn out what I initially thought it to be😔.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants