Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-24
to
+25
| return ( | ||
| today_version + f".{dev_num}", | ||
| today_version + f".dev{dev_num+1}", | ||
| ) | ||
| return ( | ||
| today_version, | ||
| today_version + ".dev1", | ||
| ) | ||
| return f'{today_version}.{dev_num}', f'{today_version}.dev{dev_num + 1}' | ||
| return today_version, f'{today_version}.dev1' |
There was a problem hiding this comment.
Function _determine_versions refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| if not foreground: | ||
| foreground = fallbacks["foreground"] | ||
| else: | ||
| foreground = f"#{foreground}" | ||
|
|
||
| foreground = fallbacks["foreground"] if not foreground else f"#{foreground}" |
There was a problem hiding this comment.
Function get_pygments_style_colors refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-116
to
-122
| if "hide-toc" in file_meta: | ||
| return True | ||
| elif "toc" not in context: | ||
| if "hide-toc" in file_meta or "toc" not in context or not context["toc"]: | ||
| return True | ||
| elif not context["toc"]: | ||
| return True | ||
|
|
There was a problem hiding this comment.
Function _compute_hide_toc refactored with the following changes:
- Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Remove redundant conditional (
remove-redundant-if)
Comment on lines
-137
to
+128
| index = static.index("_static/" + asset) | ||
| index = static.index(f'_static/{asset}') |
There was a problem hiding this comment.
Function _add_asset_hashes refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-38
to
+41
| lines = [] | ||
| if not block.strip("\n"): | ||
| return StringList() | ||
|
|
||
| lines.append("````````{tab} Markdown (MyST)") | ||
| lines.append("```````md") | ||
| lines = ['````````{tab} Markdown (MyST)', '```````md'] |
There was a problem hiding this comment.
Function _md_demo refactored with the following changes:
- Merge extend into list declaration (
merge-list-extend) - Move assignment closer to its usage within a block (
move-assign-in-block) - Merge consecutive list appends into a single extend (
merge-list-appends-into-extend)
Comment on lines
-53
to
+64
| lines = [] | ||
| if not block.strip(): | ||
| return StringList() | ||
|
|
||
| lines.append("````````{tab} reStructuredText") | ||
| lines.append("```````{eval-rst}") | ||
| lines.append(".. code-block:: rest") | ||
| lines.append("") | ||
| lines = [ | ||
| '````````{tab} reStructuredText', | ||
| '```````{eval-rst}', | ||
| '.. code-block:: rest', | ||
| '', | ||
| ] | ||
|
|
||
| lines.extend(indent(block, " ").splitlines()) | ||
| lines.append("") | ||
| lines.extend(block.splitlines()) | ||
| lines.append("```````") | ||
| lines.append("````````") | ||
|
|
||
| lines.extend(("```````", "````````")) |
There was a problem hiding this comment.
Function _rst_demo refactored with the following changes:
- Merge extend into list declaration (
merge-list-extend) - Move assignment closer to its usage within a block (
move-assign-in-block) - Merge consecutive list appends into a single extend (
merge-list-appends-into-extend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!