Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init-letsencrypt.sh to support subdomain configurations #1380

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

keironstoddart
Copy link
Contributor

Sometimes a user wants to specify an explicit subdomain for the establishment of the SSL certificate. In this case, you do not want to append www to the domain in the list of domains to test the Let's Encrypt certification process against.

Add ability to accept a `.ev.nginx` configuration that lists a subdomain.
Copy link

vercel bot commented Apr 25, 2024

@keironstoddart is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

@keironstoddart
Copy link
Contributor Author

Hi @yuhongsun96, let me know if you need any more information here. I love everything you guys have done here and I believe this minor update will be well received.

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

@yuhongsun96 yuhongsun96 merged commit b6d0ece into danswer-ai:main Jun 4, 2024
1 check failed
@keironstoddart
Copy link
Contributor Author

Cheers! You are most welcome.

hagen-danswer pushed a commit to hagen6835/danswer that referenced this pull request Jun 5, 2024
Add ability to accept a `.ev.nginx` configuration that lists a subdomain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants