♻️ refactor: Login and Registration component Improvement #2716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've made some improvements to the
Login
andRegistration
components.Login
andRegistration
displayed a blank screen while fetchingStartupConfig
data from the API. I've added a blinking logo that appears while the forms wait for the API to return theStartupConfig
data. No worries, if you don't like this effect, you can simply remove the BlinkAnimation wrapper.1.mov
Login
component only to make one API call for StartupConfig, even if the component re-renders after a failed login attempt.I initially planned to make just a small improvement, but it turned into a bit of a larger change. However, the functionality of the
Login
andRegistration
components remains the same.Please let me know if you have any concerns. I hope these changes can help improve the user experience, even if just a little bit.
Change Type
Checklist