Enable detecting SyncTERM DA1 response. #2743
Conversation
SyncTERM sends CSI = Pn c not CSI ? Pn c like VT terminals. This results in notcurses hanging in init. This required WezTerm da3 support to be removed, because the SyncTERM and WezTerm responses could not both exist in the automaton. As it turns out, a dig through the WezTerm git history shows that it never actually sent CSI = ... ST in response to DA3, and notcurses took no actions in response to it, so it should be safe to remove this feature.
SyncTERM has constant values after CSI =, so may as well avoid false matches.
|
is SyncTERM used? the webpage looks pretty ... unmaintainted. good work either way, nice investigation. |
|
Yeah, it's used (and designed) as a client for BBSs. The web page was recently (within the last month) updated to incorporate all the important feedback from the users. Even I don't use it as a general-purpose terminal emulator since it's explicitly not VT-compatible, and it doesn't support Unicode (though I may do that soon). I whipped it up to scratch my own itch, and am constantly surprised that other people use it too. A new version will be released "Really Soon Now". Only reason I became aware of the issue is because a user accused SyncTERM of hanging. 😄 |
|
Some more background, this is affecting this game: |
|
sorry, forgot all about this. i'll try hard to look into this asap! |
| @@ -1378,15 +1394,6 @@ da2_cb(inputctx* ictx){ | |||
| return 2; | |||
| } | |||
|
|
|||
| // weird form of Ternary Device Attributes used only by WezTerm | |||
There was a problem hiding this comment.
i'm not sure i understand why you're getting rid of the wezterm handler?
|
I'll let Deuce chime in more with that one, but my understanding is they overlapped in the automaton (that is to say, they both couldn't be detected independently), and after reviewing the wezterm code along with its history, it looks like it never responded to DA3 with CSI = ... ST |
SyncTERM sends CSI = Pn c not CSI ? Pn c like VT terminals. This results in notcurses hanging in init.
This required WezTerm da3 support to be removed, because the SyncTERM and WezTerm responses could not both exist in the automaton. As it turns out, a dig through the WezTerm git history shows that it never actually sent CSI = ... ST in response to DA3, and notcurses took no actions in response to it, so it should be safe to remove this feature.