Update ruby version in Dockerfile to 3.2 #1472 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker build` fails with the message "bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.225." it seems to be caused by [email protected] requires [email protected]
|
This MR will also fix the failing execution og Danger in ruby 2.x environment due to the transitive dependency on faraday. Faraday release v2.9.0 deprecated the support of ruby 2.x. |
manicmaniac
reviewed
Feb 3, 2024
| @@ -7,7 +7,7 @@ inherit_mode: | |||
| # Defaults can be found here: https://github.com/bbatsov/rubocop/blob/master/config/default.yml | |||
|
|
|||
| AllCops: | |||
| TargetRubyVersion: 2.7 | |||
| TargetRubyVersion: 3.2 | |||
There was a problem hiding this comment.
Changing this line causes many lint errors. I think it should be remained as it is for now.
|
@okatatuki Sorry for the delay in my review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildfails with the message "bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.225." it seems to be caused by [email protected] requires [email protected]fix #1472
Or should I lower the bundler version?