Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to create discussion instead of note #1468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to create discussion instead of note #1468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/danger/request_sources/gitlab.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def initialize(ci_source, environment)
@endpoint = environment["DANGER_GITLAB_API_BASE_URL"] || environment.fetch("CI_API_V4_URL", "https://gitlab.com/api/v4")
@host = environment.fetch("DANGER_GITLAB_HOST", URI.parse(endpoint).host) || "gitlab.com"
@token = environment["DANGER_GITLAB_API_TOKEN"]
@use_threads = environment.fetch("DANGER_GITLAB_USE_THREADS", "").match?(/true|1/i)
end

def client
Expand Down Expand Up @@ -218,7 +219,11 @@ def update_pull_request_with_inline_comments!(warnings: [], errors: [], messages

comment_result =
if should_create_new_comment
client.create_merge_request_note(ci_source.repo_slug, ci_source.pull_request_id, body)
if @use_threads
client.create_merge_request_discussion(ci_source.repo_slug, ci_source.pull_request_id, { body: body })
else
client.create_merge_request_note(ci_source.repo_slug, ci_source.pull_request_id, body)
end
else
client.edit_merge_request_note(ci_source.repo_slug, ci_source.pull_request_id, last_comment.id, body)
end
Expand Down