Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use in_reply_to_id to lookup GitHub replies #1401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kemchenj
Copy link

Currently, danger's comment replies lookup logic for GitHub is basically guessing, cause at that time GitHub doesn't have a concept for "reply".

The good news is GitHub API has filled this pit:

// https://docs.github.com/en/rest/pulls/reviews#list-reviews-for-a-pull-request
"in_reply_to_id": {
  "description": "The comment ID to reply to.",
  "type": "integer",
  "examples": [
    8
  ]
}

So let's move on with this new right way.

@manicmaniac
Copy link
Member

@kemchenj

Looks really nice 👍
Could you add some tests for this change?

At a glance, there seems no tests for inline comments with replies but this test case looks similar.

it "removes inline comments if they are not included" do

@orta
Copy link
Member

orta commented Nov 16, 2022

Does anyone know when this was added? Older GitHub enterprises may not have this in their API, which is what I'd be wary of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants