Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance local repository regex matching conditions #1229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance local repository regex matching conditions #1229

wants to merge 1 commit into from

Conversation

jguttman94
Copy link

The existing regex expression is not complex enough to handle projects within groups/subgroups in GitLab.

See this regex101 for EXISTING support
See this regex101 for PROPOSED support

The existing regex expression is not complex enough to handle projects within groups/subgroups in gitlab.
See this regex101 for examples:
https://regex101.com/r/oFaZZp/1
@danger-public
Copy link

danger-public commented Jul 9, 2020

2 Errors
🚫 Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.
🚫 Tests have failed, see below for more information.
1 Warning
⚠️ Tests were not updated

Tests:

File Name
gitlab_spec.rb Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments deletes non-sticky comments if no violations are present
gitlab_spec.rb Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments deletes inline comments if those are no longer relevant
gitlab_spec.rb Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments edits existing inline comment instead of creating a new one if file/line matches
gitlab_spec.rb Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments skips inline comments for files that are not part of the diff

Generated by 🚫 Danger

@orta
Copy link
Member

orta commented Mar 10, 2021

These test fails could be legit?

@orta
Copy link
Member

orta commented May 20, 2021

poke

@jguttman94
Copy link
Author

apologies, haven't been very active recently. these very well could be valid test failures, and since it's been a long time since I opened this PR, I've forgotten what scenario spawned this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants