dlt Resource Failure Aware Asset Materialization #21856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmpadden
reviewed
May 15, 2024
| @@ -90,7 +90,8 @@ def extract_resource_metadata( | |||
| job | |||
| for load_package in load_info_dict.get("load_packages", []) | |||
| for job in load_package.get("jobs", []) | |||
| if job.get("table_name") == resource.table_name | |||
| if resource.table_name | |||
| in [table.get("table_name") for table in load_package.get("tables", [])] | |||
There was a problem hiding this comment.
I'm curious if using table_name will work if a destination like s3 (or local filesystem) is used, since these aren't considered tables.
Would it be possible to get the failure for the resource name instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
There are some situations where some dlt jobs fail but Dagster reports successful materializations of the dlt assets. This PR ensures that reported materialization events correctly map to successful dlt resources without failed jobs.
How I Tested These Changes
make pyright (ensured the proposed changes did not introduce any errors, but other libraries were generating errors when running locally)
make ruff
python -m pytest python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/dlt_tests