[docs] - Update Schedule API docs (DOC-236) #21838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinkcochran87
changed the title
tacastillo
requested changes
May 22, 2024
There was a problem hiding this comment.
Generally looks good to me, but looks like there was a rough merge that accidentally pulled in some old (or new?) changes in some of the actual codebase! Feel free to hit re-review when that merge is fixed.
Also left a couple comments to hone in on some edges.
python_modules/dagster/dagster/_core/definitions/decorators/schedule_decorator.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/definitions/time_window_partitions.py
Outdated
Show resolved
Hide resolved
This reverts commit 1e611db.
…r-io/dagster into erin/doc-236-api-schedule
erinkcochran87
commented
May 22, 2024
python_modules/dagster/dagster/_core/definitions/time_window_partitions.py
Outdated
Show resolved
Hide resolved
tacastillo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR updates the Schedule API docs by adding information to the reference page itself as well as some of the API descriptions.
How I Tested These Changes
eyes + local, ruff + BK