Fix refcounting of default arguments with CYTHON_AVOID_BORROWED_REFS #6130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects PyPy
and Limited APII think.References to the function default arguments were being incremented but never decremeneted in the case where the argument was actually provided. I suspect this mostly didn't matter, since arguments are usually just globals with an extended lifetime, but it's worth getting right.
For the more common case where we aren't avoiding borrowed refs, the ref counting becomes a no-op so it doesn't matter.
Needs backporting to 3.0.x (so I'd rather use
%
formatting than update to fstrings)