chore: Move what-is-circular dep within Cypress repo #29530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,26 @@ | |||
| const lodash = require('lodash') | |||
There was a problem hiding this comment.
Previous file here: https://github.com/cypress-io/what-is-circular/blob/master/index.js
| @@ -0,0 +1,192 @@ | |||
| import { whatIsCircular } from '../../../src/util/what-is-circular' | |||
There was a problem hiding this comment.
Previous test here: https://github.com/cypress-io/what-is-circular/blob/master/test.js
Passing run #55457 ↗︎
Details:
Review all test suite changes for PR #29530 ↗︎ |
|||||||||||||||
mschile
approved these changes
May 16, 2024
AtofStryker
approved these changes
May 17, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This moves the code from the https://github.com/cypress-io/what-is-circular directly into Cypress.
The https://github.com/cypress-io/what-is-circular repo was a fork of https://github.com/flotwig/what-is-circular which was inspired by https://github.com/tjmehta/is-circular/, but returns the path to the first circular reference found.
I think having this code directly in the repo is beneficial since it's a single file, has tests, and requires no maintenance on our part to run extra CI/release processes in a separate repo if a change is needed. It also deters outside users from including the package, creating an expectation for us to maintain it for them.
Steps to test
Unit tests transferred within utils that should run in the driver tests. Other tests should pass.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?