fix: preserve navigation functionality when unload event is deprecated
#29525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
cacieprins
changed the title
unload event is deprecated
jennifer-shehane
requested changes
May 15, 2024
There was a problem hiding this comment.
@cacieprins I'm not sure I would even advocate for exposing page:show and page:hide until users directly ask for it.
Shouldn't we update the onUpload callback to onPageHide?
jennifer-shehane
approved these changes
May 16, 2024
AtofStryker
approved these changes
May 17, 2024
1 flaky test on run #55532 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property isnt a digit or `all` |
Test Replay
|
|
Review all test suite changes for PR #29525 ↗︎
| @@ -344,7 +344,9 @@ export class EventManager { | |||
| // when we actually unload then | |||
| // nuke all of the cookies again | |||
| // so we clear out unload | |||
| $window.on('unload', () => { | |||
| const unloadEvent = this.isBrowser({ family: 'chromium' }) ? 'pagehide' : 'unload' | |||
There was a problem hiding this comment.
@cacieprins Can you add a note about why we decided to only target chromium here?
There was a problem hiding this comment.
Added in a64d262
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unloadevent deprecation within Chrome #29241Additional details
In order to prepare for Chrome's removal of the
unloadevent, we are migrating to usingpagehideas a proxy for internal navigation detection. In order to preservewindow:unload, for now, this event is also triggered onpagehide. Because the event emitted onpagehideis a superset ofEvent, which is emitted onunload, this is not a breaking change.Future steps to support deprecation of
unload:window:pageshowandwindow:pagehideeventswindow:unloadis usedSteps to test
Existing tests should pass with the flags removed. To test full
unloadremoval, uncomment the indicated flags inpackages/server/lib/util/chromium_flags.ts.How has the user experience changed?
window:unloadmay fire both more reliably and at a slightly different point in the page lifecycle timeline. Otherwise, it should not be impacted.PR Tasks
cypress-documentation?type definitions?