fix: no longer use capture script url as default upload url for test replay recordings #29512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
approved these changes
May 13, 2024
9 flaky tests on run #55469 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > past Max-Age, before Expires -> not logged in |
| |||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an fetch request is canceled |
Test Replay
|
|
project-setup.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| Launchpad: Setup Project > switch testing types > takes the user to first step of e2e setup when switching from app |
Test Replay
Screenshots
|
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws after timing out after a .wait() alias reference |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #29512 ↗︎
ryanthemanuel
approved these changes
May 17, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When Cloud responds to the instance results POST with an empty protocol upload url, the artifact upload logic was defaulting to using the URL of the capture protocol script. This URL does not accept uploads, and was causing HTTP errors similar to
Failed to upload after 1 attempts. Errors: Request Entity Too Large. Instead of attempting to upload to this URL, Cypress will now report to stdout that the upload URL for Test Replay was missing or invalid, and it cannot upload the recording. Further investigation is necessary into why Cypress Cloud is returning an undefined upload url for runs that have Test Replay enabled.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?