Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deps): update CircleCI Cypress Orb to v3 #314

Closed
wants to merge 3 commits into from

Conversation

MikeMcC399
Copy link
Contributor

Issue

circle.yml uses an outdated version:

  • cypress: cypress-io/cypress@1

The repo is configured in the following to use Cypress 13.x

"cypress": "13.12.0",

A minimum of Cypress Orb v2 is however needed for Cypress v10 (and higher) compatibility.

Change

Update circle.yml to use the current version v3 of the CircleCI Cypress Orb:

  • cypress: cypress-io/cypress@3

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Contributor Author

CircleCI is not triggering. Possibly due to this being a PR from a fork?

@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 25, 2024 12:45
@jennifer-shehane
Copy link
Member

Yah I saw this on another PR of yours

@jennifer-shehane
Copy link
Member

@MikeMcC399 I updated the circleci settings so that forked pull requests should now run.

@jennifer-shehane jennifer-shehane self-requested a review June 25, 2024 20:37
@MikeMcC399 MikeMcC399 marked this pull request as draft June 26, 2024 07:15
@MikeMcC399
Copy link
Contributor Author

The workflow fails and needs further investigation:

Error calling workflow: 'build'
Error calling job: 'cypress/run'
Unexpected argument(s): start, record, executor

@MikeMcC399
Copy link
Contributor Author

The arguments for cypress/run have changed between v1 and v3 and I can't find any migration guide.

I'm closing this PR. I need to leave it to somebody with CircleCI / Cypress Orb experience.

@MikeMcC399 MikeMcC399 closed this Jun 26, 2024
@MikeMcC399 MikeMcC399 deleted the update/cypress-orb branch June 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants