Fix multilabel widerface import #7266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amjadsaadeh
requested review from
azhavoro,
zhiltsov-max,
bsekachev,
mdacoca,
SpecLad,
Marishka17 and
nmanovic
as code owners
Whenever a dataset in widerface format with multiple labels were imported, a frame matching execption has been caused in the importer. This commit fixes it by using additional fuzzy matching, which has been also used in fining the root hint.
amjadsaadeh
force-pushed
the
fix-multilabel-widerface-import
branch
from
730b88c
to
6664dc6
Compare
zhiltsov-max
removed request for
SpecLad,
mdacoca,
bsekachev,
azhavoro and
Marishka17
|
Hi, thank you for the contribution! I think it's an interesting addition to the frame matching function. We need to double check the new behavior in the corner cases such as:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
In #7265 I already mentioned a bug when importing the WiderFace dataset, caused by multiple labels within the dataset. This pull request is intended to fix this bug.
How has this been tested?
wider_face_cvat.zip
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.