Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable django disk usage health check #7180

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −2
Open

feat: Disable django disk usage health check #7180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04c4b4
feat: Disable django disk usage health check
Podesta Nov 25, 2023
e5ea12c
docs: Add changelog fragment
Podesta Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.d/20231125_005843_Podesta_remove_disk_health_check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Changed

- Django's health-check no longer checks for disk usage.
(<https://github.com/opencv/cvat/pull/7180>)
6 changes: 6 additions & 0 deletions cvat/settings/production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,9 @@
# https://github.com/moggers87/django-sendfile2
SENDFILE_BACKEND = 'django_sendfile.backends.nginx'
SENDFILE_URL = '/'

# Checking for disk usage should be the user responsibility
# https://django-health-check.readthedocs.io/en/stable/settings.html
HEALTH_CHECK = {
'DISK_USAGE_MAX': None,
}
3 changes: 1 addition & 2 deletions cvat/settings/testing_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
IMPORT_CACHE_CLEAN_DELAY = timedelta(seconds=30)

# The tests should not fail due to high disk utilization of CI infrastructure that we have no control over
# But let's keep this check enabled
HEALTH_CHECK = {
'DISK_USAGE_MAX': 100, # percent
'DISK_USAGE_MAX': None,
}