tests: silence -Wsign-conversion, type tidy-ups
#13469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
vszakats
force-pushed
the
signwarn-03
branch
2 times, most recently
from
6b5ddd6
to
15623fd
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 27, 2024
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 29, 2024
vszakats
changed the title
-Wsign-conversion-Wsign-conversion, type tidy-ups
Also libtest non-CURLcode issues.
|
Closing in favour of #13501 and cherry-picking from there. It has the same commits as this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence and fix sign conversion issues and compiler warnings
in tests. Also switch all unit tests to return
CURLcode. Beforethis patch all unit tests and about a third of libtests did this.
Also fix mask signedness and/or types in some
printfcalls.Ref: #13467
Cherry-picked from #13489
Follow-up to 3829759 #12489
Closes #13469