explicitly include MacTypes.h
#13429
Conversation
The latest macos sdk release - 15.3, seems to have broken a transitive include for OSStatus types used in sectransp.c The fix here is to explicitly include the header that declares these symbols.
|
It turns out this is not the only missing include... Will update in a sec |
This reverts commit 9876b6e.
This turned out to be an issue with our build configurations - but the |
|
Is it? I'm able to build the latest source using Xcode 15.3 with no problems, so I'm not convinced this change is needed. |
Sorry for the delayed response. I think I might've jumped the gun with this change - I meant valid in the sense that it's a transitive include that AFAIK isn't pulled in by some dedicated omnibus header. We got caught off guard by lots of mac builds suddenly breaking around this and related errors and this seemed to be necessary to fix the problem - so I wanted to upstream it quickly in case we could avoid using a fork or adding custom patches. What I ended up doing is re-evaluating why we're building macos native (and deprecated TLS), when we are already using openssl. So I ended up just building curl against that to fix the problem. We are also using a non-standard build system so this error is going to be hard to reproduce outside of our codebase. In the end this is an extremely trivial change that'll unlikely to majorly hurt or help anyone so I am totally ok with closing this! Thanks for the responsiveness and I'll be careful to not jump the gun if I ever end up contributing here again in the future. |
|
Thanks for the update, closing |
The latest macos sdk release - 15.3, seems to have broken a transitive include for OSStatus types used in sectransp.c
The fix here is to explicitly include the header that declares these symbols.