Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use plain thrust namespace in complex clone #8221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Mar 6, 2024

Thrust has introduced a wrapped versioning namespace. This is colliding with the namespace introduced in cupy/complex

To avoid that issue pull in the thrust config and use the proper thrust namespace macro

@leofang leofang self-assigned this Mar 6, 2024
@leofang leofang added the to-be-backported Pull-requests to be backported to stable branch label Mar 6, 2024
Thrust has introduced a wrapped versioning namespace. This is colliding with the namespace introduced in `cupy/complex`

To avoid that issue pull in the thrust config and use the proper thrust namespace macro
@leofang
Copy link
Member

leofang commented Mar 7, 2024

/test mini

@leofang
Copy link
Member

leofang commented Mar 8, 2024

There are build- and run- time compilation failures regarding missing <cstddef> include. For run-time ones it's clear, since NVRTC doesn't have it, and we weren't expected to add it without the help of Jitify. We probably need to bump the CCCL submodule so that NVIDIA/cccl#1081 is included (but I thought it already was?). For build-time ones, it's coming from NVCC/MSVC and is really odd. @miscco any chance you know MSVC may have issues in finding cstddef?

@leofang
Copy link
Member

leofang commented Mar 8, 2024

We probably need to bump the CCCL submodule so that NVIDIA/cccl#1081 is included (but I thought it already was?).

Ah I see, the submodule was pinned around last September, but that PR was merged in November, so it's not included yet.

@miscco
Copy link
Contributor Author

miscco commented Mar 8, 2024

@miscco any chance you know MSVC may have issues in finding cstddef?
Nope, not that I am aware of

@kmaehashi kmaehashi added the cat:code-fix Code refactoring that do not change behavior label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:code-fix Code refactoring that do not change behavior to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants