Do not do shortcut merge batch operations, do it one by one for toSlateOp #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulion
force-pushed
the
feature/merge_node_re_implement
branch
from
0ab77fb
to
dfbb596
Compare
|
Added a few commits to handle property remove operation (introduced by the other merged set undefined -> delete property commit.) |
|
the newest one commit added is for this issue: fbcbef0#r46907440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a fast fix for merge_node like operations. since currently, the map are collected in the first round run, then the 2nd round run to generate slate ops. but, during that, the path could change due to remove or insert node. In some complex data structure cases, it will cause error, mainly can not find slate path.
So now this quick do it one by one, step by step, with the current step map and temp doc tree. no shortcut, just do it one by one.
The code is not fully tested, but it passed two merge_node crash cases in my usage. will keep this up to date if there will be any fix follow up.