Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cucumber expression AST and parser (#124) #153

Closed
wants to merge 23 commits into from
Closed

Cucumber expression AST and parser (#124) #153

wants to merge 23 commits into from

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Nov 2, 2021 •
edited
Loading

Part of #124

Synopsis

This is the first PR in the story of Cucumber expressions support.

Solution

This PR implements Cucumber expressions AST and a parser for it. Next PRs will be adding AST into regex transformation and support inside proc-macros.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Nov 2, 2021
@ilslv ilslv added this to the 0.11 milestone Nov 2, 2021
@ilslv ilslv self-assigned this Nov 2, 2021
@ilslv
More custom errors [skip ci]
180b95d
@ilslv
More custom errors [skip ci]
bd7c640
@ilslv
More custom errors [skip ci]
9bae945
@ilslv
Add docs and spec for escaped0 [skip ci]
959cdd5
@ilslv
Separate parser combinators and document them
a774ffd
@ilslv
Document and add spec for parameter()
ef7b8cf
@ilslv
Document and add spec for parameter() [skip ci]
3403951
@ilslv
Document and add spec for parameter() [skip ci]
f7a2851
@ilslv
Document and add spec for optional() [skip ci]
fbeb537
@ilslv
Document and add spec for optional() [skip ci]
f466e18
@ilslv
Document and add spec for alternative() [skip ci]
5775823
@ilslv
Document and add spec for alternation() and fix alternative() [skip ci]
b2dfabf
@ilslv
Document and add spec for expression() [skip ci]
3470bf9
@ilslv
Document and add spec for expression() [skip ci]
a883b52
@ilslv
Tidy up [skip ci]
e633df6
@ilslv
Add README [skip ci]
c2042c1
@ilslv
Add CHANGELOG [skip ci]
290144b
@ilslv
Corrections
85ae536
@ilslv
Merge branch 'main' into 124-cucumber-expression
2b11992
@ilslv
Corrections
12b35ac
@ilslv
Copy link
Member Author

ilslv commented Nov 5, 2021

FCM

Cucumber expression AST and parser (#153, #124)

@ilslv ilslv changed the title Draft: Cucumber expressions support (#124) Draft: Cucumber expression AST and parser (#124) Nov 5, 2021
@ilslv ilslv linked an issue Nov 5, 2021 that may be closed by this pull request
Are “Cucumber Expressions” supported ? #124
Closed
@ilslv ilslv marked this pull request as ready for review November 5, 2021 10:47
@ilslv ilslv changed the title Draft: Cucumber expression AST and parser (#124) Cucumber expression AST and parser (#124) Nov 5, 2021
@ilslv ilslv requested a review from tyranron November 5, 2021 10:47
@tyranron tyranron mentioned this pull request Nov 6, 2021
Merged
15 tasks
tyranron
tyranron requested changes Nov 6, 2021
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a separate repo: cucumber-rs/cucumber-expressions#1

Closing this.

expression/Cargo.toml
@@ -0,0 +1,23 @@
[package]
name = "cucumber-expression"
version = "0.11.0-dev" # should be the same as main crate version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this crate can be versioned separately.

@tyranron tyranron closed this Nov 6, 2021
@tyranron tyranron deleted the 124-cucumber-expression branch November 6, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron requested changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Are “Cucumber Expressions” supported ?
2 participants
@ilslv @tyranron