Cucumber Expressions AST into Regex expansion #2
Conversation
|
UPD: Waiting for JelteF/derive_more#175 |
Co-authored-by: Ilya Solovyiov <[email protected]>
# Conflicts: # Cargo.toml # README.md # src/ast.rs # src/combinator.rs # src/lib.rs # src/parse.rs
FCM |
| /// | ||
| /// [0]: Expression#parameter-types | ||
| /// [`Error`]: ExpansionError | ||
| pub fn regex_with_parameters<Input, Parameters>( |
There was a problem hiding this comment.
It's hard to grasp the whole idea here. Can we provide a meaningful example?
| -> <SingleExpression<Input> as IntoRegexCharIter<Input>>::Iter, | ||
| >, | ||
| >, | ||
| iter::Once<Result<char, UnknownParameterError<Input>>>, |
There was a problem hiding this comment.
Once we have TAIT we won't need this aliases anymore. It's worth mentioning with TODO comment for future.
src/expand/mod.rs
Outdated
| // except according to those terms. | ||
|
|
||
| //! [Cucumber Expressions][0] [AST] into [`Regex`] transformation | ||
| //! definitions. |
There was a problem hiding this comment.
We also need to mention somewhere upstream production rules.
If we align with them 1-to-1, then they should be referred in transformation functions docs directly.
src/lib.rs
Outdated
| #[cfg(feature = "expand-into-regex")] | ||
| #[doc(inline)] | ||
| pub use self::expand::{ | ||
| ExpansionError as Error, IntoRegexCharIter, ParametersProvider, |
There was a problem hiding this comment.
I think we can omit re-exporting feature in root. They're quite specific to live in their on module.
src/expand/mod.rs
Outdated
| SingleAlternation, SingleExpression, Spanned, | ||
| }; | ||
|
|
||
| pub use with_parameters::{ParametersProvider, WithParameters}; |
There was a problem hiding this comment.
Could it be?
pub mod parameters;
pub use parameters::{Provider as ParametersProvider, WithCustom as WithCustomParameters};
tyranron
changed the title
Moved from cucumber-rs/cucumber#154
Part of cucumber-rs/cucumber#124
Synopsis
This
PRimplementsCucumber expressionsASTintoRegexexpansion.Solution
This is done with
IntoRegexCharItertrait to avoid unnecessary overhead.Checklist
Draft:prefixDraft:prefix is removed