Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding possibility of specifying listening interface #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

feriniguez
Copy link

When docker "host" network is used and the host has more than one interface, it is desirable to select the interface you want ntp to be listening to.

This small change allows to set a new variable.

in network host mode it is desirable to listen in only one interface. This allow to set a new env variable $LISTENIFACE
@cturra
Copy link
Owner

cturra commented Nov 2, 2023

thanks for your patience with my review here... while i can appreciate this is an important feature for you, it deviates a bit away from the original intent, which is to expose as little as possible from the host system. network host is not something in this project, but instead just --publish: 123:123/udp.

i understand you have a need for this and would encourage you to keep you fork up to date with this main project repo. if others in the community think i am completely of the mark here, i'd be open to hearing it, so please feel free to comment on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants