Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Use mini-css-extract instead of extract-text-plugin #569

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

diondirza
Copy link
Contributor

Using mini-css-extract plugin improve our page load time, since css will be trimmed per view usage, instead of load big chunk unused style in single css file its better to have css loaded on demand, based on page view

@unleashit
Copy link

I think this is a great idea as long as it can support having a global css and css modules. I'm assuming if you put an import in a top level component (and don't use css modules in webpack) that would solve the global problem. Will this just work out of the box with import() and react-async-component? How cool.

@oyeanuj
Copy link
Contributor

oyeanuj commented Jul 28, 2018

@diondirza @unleashit how is this working out for you so far? Good to merge or are there known issues?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants